build: migrate prettier config to typescript and remove eslint-plugin-prettier #540
Conversation
michaelfaith
force-pushed
the
build/move-to-prettier-ts
branch
from
d107e8e to
a84f50c
Compare
|
This is failing because the 
I'm going to add |
|
That worked 
But there's still an issue with one of the lint commands. Looking into it |
|
What I'm finding is that when we run on a version of node that doesn't include native type stripping (22.17.1), the eslint docs config that uses the prettier api directly can't load the
So, what I'm thinking I'll do, is put a separate PR to change all of the relative import paths to use What's especially interesting, is I wasn't able to reproduce the error locally (hence all of the test commits lol) Edit: I actually think it's more to do with #542 now. But it'll still be good to do the other change, to support native node type stripping. |
…-prettier This change moves from using `eslint-prettier-plugin` to using `eslint-config-prettier` and prettier directly for format checking. A result of us never running prettier on the root files, is that there were some adjustments needed. I ran prettier on the repo and have added those changes too. Lastly, I moved the config to `typescript`.
michaelfaith
force-pushed
the
build/move-to-prettier-ts
branch
from
3fe4a5d to
262946e
Compare
| 'plugin:unicorn/recommended', | ||
| ), | ||
| pluginN.configs['flat/recommended'], | ||
| prettier, |
There was a problem hiding this comment.
I think we technically want to include this last to ensure it overrides any incompatible config?
eslint.config.js (flat config): Import eslint-config-prettier, and put it in the configuration array – after other configs that you want to override.
There was a problem hiding this comment.
I will generally put the prettier config after all of the reusable configs, but before any configs that I've created with overrides / additional rules. The idea being that anything I add myself is an intentional choice and should take precedence, which I think aligns with the spirit of that documentation. With that said, it's currently before the TS Configs, so I should at least move it to be after those (I authored this PR before adding the TS configs). Would you prefer I move it all the way to the end or just after the ts configs?
There was a problem hiding this comment.
Your reasoning makes sense. I'll leave it up to you.
| "lint": "npm-run-all --continue-on-error --aggregate-output --parallel lint:*", | ||
| "lint:docs": "markdownlint \"**/*.md\"", | ||
| "lint:eslint-docs": "npm-run-all -s build \"update:eslint-docs -- --check\"", | ||
| "lint:js": "eslint --cache --ignore-pattern \"**/*.md\" .", |
There was a problem hiding this comment.
No, it's optional. It defaults to current working directory. I can add it back, if you prefer?
This change moves from using
eslint-prettier-pluginto usingeslint-config-prettierand prettier directly for format checking.A result of us never running prettier on the root files, is that there were some adjustments needed. I ran prettier on the repo and have added those changes too.
Lastly, I moved the config to
typescript.